Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid having the same message CID show up in execution traces #4350

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Avoid having the same message CID show up in execution traces #4350

merged 3 commits into from
Oct 14, 2020

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Oct 13, 2020 •
edited
Loading

The relevant changes are:

  • Don't doTransfer 0 FIL in UpgradeFaucetBurnRecovery
  • Use currHeight as the nonce for implicit messages (not consensus-critical, since it doesn't live on chain, and is never observed by actors)
  • Don't use the same nonce for every doTransfer

Someone should compute-state 41281 before merging this (i don't have the relevant state tree).

@arajasek arajasek changed the title Don't transfer zero FIL during rebalancing fork Avoid having the same message CID show up in execution traces Oct 13, 2020
@qiwu7
Copy link

qiwu7 commented Oct 13, 2020

Can we also compute state 50003 as an additional data point. I am getting dup message CIDs in that epoch as well. Thanks!

@arajasek
Copy link
Contributor Author

@qiwu7 The dup messages in 50003 were caused because 50002 was a null tipset, and therefore two Cron messages with identical CIDs are found in 50003's execution trace. This PR fixes that problem too.

@jleni jleni mentioned this pull request Oct 13, 2020
Closed
whyrusleeping
whyrusleeping approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@arajasek arajasek merged commit 308144e into master Oct 14, 2020
@arajasek arajasek deleted the asr/improve-fork branch October 14, 2020 05:22
@austinabell austinabell mentioned this pull request Oct 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@Kubuxu Kubuxu Kubuxu approved these changes

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arajasek @qiwu7 @whyrusleeping @Kubuxu @magik6k